diff options
| author |   mkanat%kerio.com <> | 2005-05-03 01:52:02 +0000 |
|---|---|---|
| committer | mkanat%kerio.com <> | 2005-05-03 01:52:02 +0000 |
| commit | 9d202f2d562c0cb8299c832158811f2131c73e27 (patch) | |
| tree | 97f5a0406de60ca7da9fffe0fd1cd459c6c0a201 /globals.pl | |
| parent | Bug 274724: The 'Edit Attachment' link is now available even if a user does n... (diff) | |
| download | bugzilla-9d202f2d562c0cb8299c832158811f2131c73e27.tar.gz bugzilla-9d202f2d562c0cb8299c832158811f2131c73e27.tar.bz2 bugzilla-9d202f2d562c0cb8299c832158811f2131c73e27.zip | |
Bug 289043: Implicit joins should be replaced by explicit joins - installment C
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=joel, a=justdave
Diffstat (limited to 'globals.pl')
| -rw-r--r-- | globals.pl | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/globals.pl b/globals.pl index 273f677d4..d0e819f02 100644 --- a/globals.pl +++ b/globals.pl @@ -171,13 +171,14 @@ sub GenerateVersionTable { my $mpart = $dotargetmilestone ? ", milestoneurl" : ""; - SendSQL("select name, description from classifications ORDER BY name"); + SendSQL("SELECT name, description FROM classifications ORDER BY name"); while (@line = FetchSQLData()) { my ($n, $d) = (@line); $::classdesc{$n} = $d; } - SendSQL("select name, description, votesperuser, disallownew$mpart from products ORDER BY name"); + SendSQL("SELECT name, description, votesperuser, disallownew$mpart " . + "FROM products ORDER BY name"); while (@line = FetchSQLData()) { my ($p, $d, $votesperuser, $dis, $u) = (@line); $::proddesc{$p} = $d; @@ -604,7 +605,7 @@ sub DBID_to_name { } if (!defined $::cachedNameArray{$id}) { PushGlobalSQLState(); - SendSQL("select login_name from profiles where userid = $id"); + SendSQL("SELECT login_name FROM profiles WHERE userid = $id"); my $r = FetchOneColumn(); PopGlobalSQLState(); if (!defined $r || $r eq "") { |