diff options
| author |   Alan Modra <amodra@gmail.com> | 2018-12-18 09:20:06 +1030 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2018-12-18 10:47:02 +1030 |
| commit | 7af5d5c4dda26ac36ee2ff42af8f39a10382cc41 (patch) | |
| tree | ea96ed2204aee3212b07516b827b30a0b779192f /bfd/elf32-ppc.c | |
| parent | sim: Don't overwrite stored errno in sim_syscall_multi (diff) | |
| download | binutils-gdb-7af5d5c4dda26ac36ee2ff42af8f39a10382cc41.tar.gz binutils-gdb-7af5d5c4dda26ac36ee2ff42af8f39a10382cc41.tar.bz2 binutils-gdb-7af5d5c4dda26ac36ee2ff42af8f39a10382cc41.zip | |
PR23980, assertion fail
All of the backend relocate_section functions that interpret reloc
numbers assuming the input file is of the expected type (ie. same as
output or very similar) really ought to be checking input file type.
Not many do, and those that do currently just assert. This patch
replaces the assertion with a more graceful exit.
PR 23980
* elf32-i386.c (elf_i386_relocate_section): Exit with wrong format
error rather than asserting input file is as expected.
* elf32-s390.c (elf_s390_relocate_section): Likewise.
* elf32-sh.c (sh_elf_relocate_section): Likewise.
* elf32-xtensa.c (elf_xtensa_relocate_section): Likewise.
* elf64-ppc.c (ppc64_elf_relocate_section): Likewise.
* elf64-s390.c (elf_s390_relocate_section): Likewise.
* elf64-x86-64.c (elf_x86_64_relocate_section): Likewise.
* elf32-ppc.c (ppc_elf_relocate_section): Exit with wrong format
error if input file is not ppc32 ELF.
Diffstat (limited to 'bfd/elf32-ppc.c')
| -rw-r--r-- | bfd/elf32-ppc.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/bfd/elf32-ppc.c b/bfd/elf32-ppc.c index 6b6043a0da5..2f699652363 100644 --- a/bfd/elf32-ppc.c +++ b/bfd/elf32-ppc.c @@ -7025,6 +7025,12 @@ ppc_elf_relocate_section (bfd *output_bfd, (bfd_link_relocatable (info)) ? " (relocatable)" : ""); #endif + if (!is_ppc_elf (input_bfd)) + { + bfd_set_error (bfd_error_wrong_format); + return FALSE; + } + got2 = bfd_get_section_by_name (input_bfd, ".got2"); /* Initialize howto table if not already done. */ |