dev-util/netbeans-9999: ebuild cleanup and fixes

* cleanup and fixes provided by Marco Genasci <fedeliallalinea@gmail.com>
* added some minor improvements in wording

Bug: https://bugs.gentoo.org/685782
Package-Manager: Portage-2.3.71, Repoman-2.3.17
Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

2 files changed, 50 insertions, 11 deletions

diff --git a/dev-util/netbeans-standalone/Manifest b/dev-util/netbeans-standalone/Manifest
index de74a3614..bb20651d5 100644
--- a/dev-util/netbeans-standalone/Manifest
+++ b/dev-util/netbeans-standalone/Manifest
@@ -1,4 +1,4 @@
 DIST netbeans-standalone-11.1.zip 145993657 BLAKE2B 0c4fc85771e34749b6937dd57d000899a596aa78955b063e404362f3f5c25cd97ebd8b932da6f426e3676a00cafda5ac6c31e18144cbf2a81483a8cdf1780f8d SHA512 acf971177d506535d66c0cb93c702c13eeae567bb387d50d7b9e5950d9e7909708868b76868b7ce0b664513f52b4af782bc12db66c61496abcbb3058cff7dc4f
-EBUILD netbeans-standalone-11.1.ebuild 1938 BLAKE2B 84ff9433b21214daf9a6ae1f0b2541fd6ea51a31d3dc6cbd556b9efed47f5479b397682aaeaed65a7502a8edaf1c019e82906aa74c9d1343ea16cbe848766fc8 SHA512 e9d0ab557331a672eaabc64384a54b4fc1f9e1fa4bea5c012f942a6323f2ddf31443ad25e2e814f4ff75f267d259bf42f01743943463012e6e7eaf72cce5b4c1
-EBUILD netbeans-standalone-9999.ebuild 1938 BLAKE2B 84ff9433b21214daf9a6ae1f0b2541fd6ea51a31d3dc6cbd556b9efed47f5479b397682aaeaed65a7502a8edaf1c019e82906aa74c9d1343ea16cbe848766fc8 SHA512 e9d0ab557331a672eaabc64384a54b4fc1f9e1fa4bea5c012f942a6323f2ddf31443ad25e2e814f4ff75f267d259bf42f01743943463012e6e7eaf72cce5b4c1
+EBUILD netbeans-standalone-11.1.ebuild 4537 BLAKE2B cb1a33b5994cafaeecf7ec5b8279829650fab06f51f30c18d00a0cea19cf9d84236269a131285511da2abef0c35e49a2213875b41283cc08afe99ea463ac2d69 SHA512 37d19a06470bd896848fb55c7d7a122932f0e0c620318caf4ee56034f4a4ec0512ce8db152d12ed2cbc95b2567e5b883d154c31b69d6b22866e427ce0f55e3b4
+EBUILD netbeans-standalone-9999.ebuild 4537 BLAKE2B cb1a33b5994cafaeecf7ec5b8279829650fab06f51f30c18d00a0cea19cf9d84236269a131285511da2abef0c35e49a2213875b41283cc08afe99ea463ac2d69 SHA512 37d19a06470bd896848fb55c7d7a122932f0e0c620318caf4ee56034f4a4ec0512ce8db152d12ed2cbc95b2567e5b883d154c31b69d6b22866e427ce0f55e3b4
 MISC metadata.xml 338 BLAKE2B 25922d9e4c7c4cd111db8b96e1dcb3cf026d9262b9d0861a4bcd49009303fc8535afd370e301d3f51f3127516c3b2561d6d6f56de0433a835f85fa15d1ab5012 SHA512 b7525dac3a4947550c33f096550e82644ed8a790e915a66ee627f81727f58fcbf0a055f298f8b45ee8d08da747fec79a8276a96ce0dcc43b847341166fbea4e9
diff --git a/dev-util/netbeans-standalone/netbeans-standalone-9999.ebuild b/dev-util/netbeans-standalone/netbeans-standalone-9999.ebuild
index 989f263ec..bda59d1cf 100644
--- a/dev-util/netbeans-standalone/netbeans-standalone-9999.ebuild
+++ b/dev-util/netbeans-standalone/netbeans-standalone-9999.ebuild
@@ -10,6 +10,7 @@ if [ ${PV} = "9999" ]; then
 	EGIT_REPO_URI="https://github.com/apache/netbeans.git"
 else
 	inherit java-pkg-2 java-ant-2 desktop
+	KEYWORDS="~amd64"
 	SRC_URI="https://github.com/apache/netbeans/archive/${PV}.zip -> ${P}.zip"
 	S=${WORKDIR}/netbeans-${PV}
 fi
@@ -17,8 +18,7 @@ fi
 DESCRIPTION="Apache Netbeans IDE"
 HOMEPAGE="https://netbeans.apache.org/"
 LICENSE="Apache-2.0"
-SLOT=$(ver_cut 1-1)
-KEYWORDS="~amd64"
+SLOT="$(ver_cut 1-1)"
 IUSE=""
 
 DEPEND=">=virtual/jdk-1.8:*"
@@ -27,28 +27,67 @@ RDEPEND=">=virtual/jdk-1.8:*"
 JAVA_PKG_BSFIX="off"
 INSTALL_DIR=/usr/share/${PN}-${SLOT}
 
+pkg_pretend() {
+	if has network-sandbox ${FEATURES}; then
+		eerror
+		eerror "Netbeans downloads a lot of dependencies during the build"
+		eerror "process, so you need to disable network-sandbox feature"
+		eerror "to make this ebuild proceed (FEATURES=-network-sandbox)."
+		eerror "You can also use package.env to disable this feature"
+		eerror "for the package, see:"
+		eerror
+		eerror "    https://wiki.gentoo.org/wiki//etc/portage/package.env"
+		eerror
+		die "network-sandbox is enabled, disable it to proceed";
+	fi
+}
+
 src_compile() {
 	eant -Dcluster.config=full -Dpermit.jdk9.builds=true -Dbinaries.cache="${S}"/.hgexternalcache || die "Failed to compile"
 }
 
+QA_PREBUILT="
+	usr/share/netbeans-standalone-11/ide/bin/nativeexecution/Linux-x86_64/process_start
+	usr/share/netbeans-standalone-11/ide/bin/nativeexecution/Linux-x86_64/stat
+	usr/share/netbeans-standalone-11/ide/bin/nativeexecution/Linux-x86_64/pty_open
+	usr/share/netbeans-standalone-11/ide/bin/nativeexecution/Linux-x86_64/sigqueue
+	usr/share/netbeans-standalone-11/ide/bin/nativeexecution/Linux-x86_64/unbuffer.so
+	usr/share/netbeans-standalone-11/ide/bin/nativeexecution/Linux-x86_64/killall
+	usr/share/netbeans-standalone-11/ide/bin/nativeexecution/Linux-x86_64/pty
+	usr/share/netbeans-standalone-11/profiler/lib/deployed/jdk16/linux-amd64/libprofilerinterface.so
+	usr/share/netbeans-standalone-11/profiler/lib/deployed/jdk15/linux-amd64/libprofilerinterface.so
+	usr/share/netbeans-standalone-11/profiler/lib/deployed/cvm/linux/libprofilerinterface_g.so
+	usr/share/netbeans-standalone-11/profiler/lib/deployed/cvm/linux/libprofilerinterface.so
+	usr/share/netbeans-standalone-11/platform/modules/lib/amd64/linux/libjnidispatch-440.so
+	usr/share/netbeans-standalone-11/profiler/lib/deployed/jdk16/linux-amd64/libprofilerinterface.so
+"
+
 src_install() {
 	pushd nbbuild/netbeans >/dev/null || die
 
 	insinto ${INSTALL_DIR}
 	doins -r .
+
+	rm -fr "${ED}"/${INSTALL_DIR}/ide/bin/nativeexecution/{Linux-{sparc_64,x86},MacOSX-{x86_64,x86},SunOS-{sparc,sparc_64,x86,x86_64},Windows-{x86,x86_64}} || die "Failed to remove unused binaries"
+	rm -fr "${ED}"/${INSTALL_DIR}/profiler/lib/deployed/jdk15/{hpux-pa_risc2.0{,w},linux,mac,solaris-{amd64,i386,sparc{,v9}},windows{,-amd64}} || die "Failed to remove unused libraries"
+	rm -fr "${ED}"/${INSTALL_DIR}/profiler/lib/deployed/jdk16/{hpux-pa_risc2.0{,w},linux{,-arm,-arm-vfp-hflt},mac,solaris-{amd64,i386,sparc{,v9}},windows{,-amd64}} || die "Failed to remove unused libraries"
+	rm -fr "${ED}"/${INSTALL_DIR}/profiler/lib/deployed/cvm/windows || die "Failed to remove unused libraries"
+	rm -fr "${ED}"/${INSTALL_DIR}/platform/modules/lib/{i386,x86} || die "Failed to remove unused libraries"
+	find "${ED}"/${INSTALL_DIR}/ \( -name *.exe -o -name *.dll \) -type f -exec rm {} + || die "Failed to remove unused libraries"
+
 	dodoc DEPENDENCIES NOTICE
 	dosym ${INSTALL_DIR}/bin/netbeans /usr/bin/${PN}-${SLOT}
 	fperms 755 ${INSTALL_DIR}/bin/netbeans
 
 	insinto /etc/${PN}-${SLOT}
 	doins etc/*
-	rm -fr "${D}"/${INSTALL_DIR}/etc
+	rm -fr "${ED}"/${INSTALL_DIR}/etc
 	dosym ../../../../etc/${PN}-${SLOT} ${INSTALL_DIR}/etc
-	sed -i -e "s/#netbeans_jdkhome.*/netbeans_jdkhome=\$\(java-config -O\)/g" "${D}"/etc/${PN}-${SLOT}/netbeans.conf || die "Failed to set set Netbeans JDK home"
+	sed -i -e "s/#netbeans_jdkhome.*/netbeans_jdkhome=\$\(java-config -O\)/g" "${ED}"/etc/${PN}-${SLOT}/netbeans.conf || die "Failed to set set Netbeans JDK home"
 
-	if [[ -e "${D}"/${INSTALL_DIR}/bin/netbeans ]]; then
-	sed -i -e "s:\"\$progdir\"/../etc/:/etc/${PN}-${SLOT}/:" "${D}"/${INSTALL_DIR}/bin/netbeans
-	sed -i -e "s:\"\${userdir}\"/etc/:/etc/${PN}-${SLOT}/:" "${D}"/${INSTALL_DIR}/bin/netbeans
+	if [[ -e "${ED}"/${INSTALL_DIR}/bin/netbeans ]]; then
+		sed -i -e "s:\"\$progdir\"/../etc/:/etc/${PN}-${SLOT}/:" "${ED}"/${INSTALL_DIR}/bin/netbeans
+		sed -i -e "s:\"\${userdir}\"/etc/:/etc/${PN}-${SLOT}/:" "${ED}"/${INSTALL_DIR}/bin/netbeans
 	fi
 
 	dodir /usr/share/icons/hicolor/32x32/apps
@@ -58,6 +97,6 @@ src_install() {
 
 	make_desktop_entry ${PN}-${SLOT} "Netbeans ${PV}" ${PN}-${SLOT} Development
 
-	mkdir -p  "${D}"/${INSTALL_DIR}/nb/config || die
-	echo "NBGNT" > "${D}"/${INSTALL_DIR}/nb/config/productid || die
+	mkdir -p  "${ED}"/${INSTALL_DIR}/nb/config || die
+	echo "NBGNT" > "${ED}"/${INSTALL_DIR}/nb/config/productid || die
 }