From 4674452c9296bc324d1af8bb45e30a39d2a181a2 Mon Sep 17 00:00:00 2001 From: Eli Schwartz Date: Sun, 21 Jan 2024 13:38:29 -0500 Subject: net-p2p/qbittorrent: remove libiconv dependency It was silently removed from 4.6.x as part of a bump. It was *added* long ago in commit 6b33e72d8933aca72a03b23870178adc55ec3998 with the informative and explanatory message: > Add virtual/libiconv dep I don't believe there's any valid justification for this. The application makes heavy use of Qt, and that includes using Qt's string translation features, which means it will use whatever Qt's APIs happen to use internally. Nowhere in the source code is iconv mentioned at all. If the virtual is needed then it is firmly in the realm of "citation needed". Remove it from 4.5 as well -- and the live ebuild. Signed-off-by: Eli Schwartz Signed-off-by: Sam James --- net-p2p/qbittorrent/qbittorrent-4.5.5-r2.ebuild | 1 - net-p2p/qbittorrent/qbittorrent-9999.ebuild | 1 - 2 files changed, 2 deletions(-) (limited to 'net-p2p') diff --git a/net-p2p/qbittorrent/qbittorrent-4.5.5-r2.ebuild b/net-p2p/qbittorrent/qbittorrent-4.5.5-r2.ebuild index 38a602fd3418..58cb4c88dc3d 100644 --- a/net-p2p/qbittorrent/qbittorrent-4.5.5-r2.ebuild +++ b/net-p2p/qbittorrent/qbittorrent-4.5.5-r2.ebuild @@ -29,7 +29,6 @@ RDEPEND=" >=dev-libs/openssl-1.1.1:= >=net-libs/libtorrent-rasterbar-1.2.18:= >=sys-libs/zlib-1.2.11 - virtual/libiconv gui? ( dev-libs/geoip !qt6? ( diff --git a/net-p2p/qbittorrent/qbittorrent-9999.ebuild b/net-p2p/qbittorrent/qbittorrent-9999.ebuild index c49dc5560c20..790d481629c6 100644 --- a/net-p2p/qbittorrent/qbittorrent-9999.ebuild +++ b/net-p2p/qbittorrent/qbittorrent-9999.ebuild @@ -29,7 +29,6 @@ RDEPEND=" >=dev-libs/openssl-1.1.1:= >=net-libs/libtorrent-rasterbar-1.2.19:= >=sys-libs/zlib-1.2.11 - virtual/libiconv gui? ( dev-libs/geoip !qt6? ( -- cgit v1.2.3-65-gdbad