diff options
author | Brett Cannon <brett@python.org> | 2016-02-20 18:35:41 -0800 |
---|---|---|
committer | Brett Cannon <brett@python.org> | 2016-02-20 18:35:41 -0800 |
commit | 558823a0cf7834cb8bc45123604008e33b4e69e2 (patch) | |
tree | 9f381020ea9dca25831e6fcea2aa63d76b9189e9 /Lib/importlib | |
parent | Issue #26367: Have importlib.__init__() raise RuntimeError when (diff) | |
download | cpython-558823a0cf7834cb8bc45123604008e33b4e69e2.tar.gz cpython-558823a0cf7834cb8bc45123604008e33b4e69e2.tar.bz2 cpython-558823a0cf7834cb8bc45123604008e33b4e69e2.zip |
Issue #26186: Remove an invalid type check in
importlib.util.LazyLoader.
The class was checking its argument as to whether its implementation
of create_module() came directly from importlib.abc.Loader. The
problem is that the classes coming from imoprtlib.machinery do not
directly inherit from the ABC as they come from _frozen_importlib.
Because the documentation has always said that create_module() was
ignored, the check has simply been removed.
Diffstat (limited to 'Lib/importlib')
-rw-r--r-- | Lib/importlib/abc.py | 1 | ||||
-rw-r--r-- | Lib/importlib/util.py | 5 |
2 files changed, 0 insertions, 6 deletions
diff --git a/Lib/importlib/abc.py b/Lib/importlib/abc.py index 11af22dab9b..daff681e696 100644 --- a/Lib/importlib/abc.py +++ b/Lib/importlib/abc.py @@ -4,7 +4,6 @@ from . import _bootstrap_external from . import machinery try: import _frozen_importlib -# import _frozen_importlib_external except ImportError as exc: if exc.name != '_frozen_importlib': raise diff --git a/Lib/importlib/util.py b/Lib/importlib/util.py index 1dbff2605ea..4525b3f78e4 100644 --- a/Lib/importlib/util.py +++ b/Lib/importlib/util.py @@ -263,11 +263,6 @@ class LazyLoader(abc.Loader): def __check_eager_loader(loader): if not hasattr(loader, 'exec_module'): raise TypeError('loader must define exec_module()') - elif hasattr(loader.__class__, 'create_module'): - if abc.Loader.create_module != loader.__class__.create_module: - # Only care if create_module() is overridden in a subclass of - # importlib.abc.Loader. - raise TypeError('loader cannot define create_module()') @classmethod def factory(cls, loader): |