diff options
| author |   Alan Modra <amodra@gmail.com> | 2021-10-21 19:18:34 +1030 |
|---|---|---|
| committer |   Andreas K. Hüttel <dilfridge@gentoo.org> | 2022-01-15 22:14:41 +0100 |
| commit | 3c15ad6ff44b8c2f0206d6a8b0c09ff4034771e9 (patch) | |
| tree | e151d6dab934deba09187e3cdc507d242580146a | |
| parent | gold: Place .note.gnu.property section before other note sections (diff) | |
| download | binutils-gdb-gentoo/binutils-2.37.tar.gz binutils-gdb-gentoo/binutils-2.37.tar.bz2 binutils-gdb-gentoo/binutils-2.37.zip | |
-Waddress warning in ldelf.cgentoo/binutils-2.37_p1-2gentoo/binutils-2.37
ldelf.c: In function 'ldelf_after_open':
ldelf.c:1049:43: warning: the comparison will always evaluate as 'true' for the address of 'elf_header' will never be NULL [-Waddress]
1049 | && elf_tdata (abfd)->elf_header != NULL
| ^~
In file included from ldelf.c:37:
../bfd/elf-bfd.h:1957:21: note: 'elf_header' declared here
1957 | Elf_Internal_Ehdr elf_header[1]; /* Actual data, but ref like ptr */
PR ld/28734
* ldelf.c (ldelf_after_open): Remove useless elf_header test.
(cherry picked from commit ced10cb78d01652f9e1bb1d1e465327dfe1debaa)
(cherry picked from commit c912b88e003a43e10020f56675fbd7e180d255ab)
| -rw-r--r-- | ld/ldelf.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/ld/ldelf.c b/ld/ldelf.c index 21e655bb55c..0c39eb6024f 100644 --- a/ld/ldelf.c +++ b/ld/ldelf.c @@ -1046,7 +1046,6 @@ ldelf_after_open (int use_libpath, int native, int is_linux, int is_freebsd, if (abfd->xvec->flavour == bfd_target_elf_flavour && !bfd_input_just_syms (abfd) && elf_tdata (abfd) != NULL - && elf_tdata (abfd)->elf_header != NULL /* FIXME: Maybe check for other non-supportable types as well ? */ && (elf_tdata (abfd)->elf_header->e_type == ET_EXEC || (elf_tdata (abfd)->elf_header->e_type == ET_DYN |